Skip to content

Fix ids #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 6, 2025
Merged

Fix ids #782

merged 13 commits into from
Jun 6, 2025

Conversation

ldecicco-USGS
Copy link
Collaborator

  1. Add max_results
  2. Add some logic that a user could request monitoring_location_id or monitoring_locations_id (plural) to get the "id" column from the monitoring-locations service.
  3. Add same logic that the "id" column from the time-series-metadata service actually comes back as "timeseries_id" since that is the name that other functions will require.
  4. Added some "lessons learned" in the vignette
  5. Changed the way the data is parsed if skipGeometry=TRUE. The way it was coding was dropping the "id" column, now it uses sf::read_sf even if skipGeometry=TRUE, but then drops the empty geometry.

@ldecicco-USGS ldecicco-USGS requested a review from ehinman June 5, 2025 17:14
@ldecicco-USGS
Copy link
Collaborator Author

Not sure what's going on with GitHub Actions. It was hanging forever and eventually cancelled itself. The tests ran and passed locally and on Gitlab, so for now let's assume things pass the checks/tests

@ldecicco-USGS ldecicco-USGS merged commit 646d6be into DOI-USGS:develop Jun 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehinman ehinman Awaiting requested review from ehinman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ldecicco-USGS